Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported instrument #71

Closed
severak opened this issue Jun 4, 2021 · 6 comments
Closed

Unsupported instrument #71

severak opened this issue Jun 4, 2021 · 6 comments
Labels
bug windows windows-related problems

Comments

@severak
Copy link

severak commented Jun 4, 2021

I am not able to play anything or to save is as audio.

Error message is:

Unsupported instrument: Piano 1 bank #0 preset#

Also when this message is thrown, it looks like it's improssible to close player window.

@truj
Copy link
Owner

truj commented Jun 4, 2021

Thank you for reporting this.
However I need some more information to reproduce the problem.

  • Did you load any soundfont? If yes, which one?
  • Can you provide the file you imported?
  • Which file extension and Audio Export Settings did you use for the export?
  • Which OS and Java version do you use?

@truj truj added the bug label Jun 4, 2021
@severak
Copy link
Author

severak commented Jun 4, 2021

Did you load any soundfont? If yes, which one?

it don't work both with and without soundfont. When I used soundfont, I used tiny_Carillon.sf2 and GeneralUser GS MuseScore v1.442.sf2 (this is from MuseScore website)

Can you provide the file you imported?

https://github.com/truj/midica/blob/master/examples/old_macdonald_had_a_farm.midica

(and some Alda files I have on disc)

Which file extension and Audio Export Settings did you use for the export?

wav

Which OS and Java version do you use?

Windows 7

java version "1.8.0_261"
Java(TM) SE Runtime Environment (build 1.8.0_261-b12)
Java HotSpot(TM) 64-Bit Server VM (build 25.261-b12, mixed mode)

@truj
Copy link
Owner

truj commented Jun 4, 2021

On Windows I can reproduce the problem. (I use Linux usually.)
It occurs in the player as well. Seems to be a gervill-related problem.
I'll check that.

@truj truj added the windows windows-related problems label Jun 6, 2021
@truj
Copy link
Owner

truj commented Jun 6, 2021

On windows, gervill uses a default DLS soundbank instead of a default SF2 soundbank.
DLS is not yet supported in Midica.
Probably it will take me a few days to fix this.

Until then, the following workarounds are possible:

truj added a commit that referenced this issue Jun 7, 2021
truj added a commit that referenced this issue Jun 7, 2021
- probably needs more work to run on windows again
- #71
truj added a commit that referenced this issue Jun 7, 2021
- avoiding DLS as it's not yet implemented
- removing JARSoundbankReader (not used but causes problems in higher Java versions)
- #71
@truj
Copy link
Owner

truj commented Jun 7, 2021

I think I fixed it.
At least it's now running for me in the following combinations:

  • Windows 10 / Java 13
  • Linux / OpenJDK 8
  • Linux / OpenJDK 16
  • Linux / Oracle Java 8

Can you please try out if your combination (Windows 7 / Java 1.8) works as well with release 1.4.1

@severak
Copy link
Author

severak commented Jun 7, 2021

Now everything works. Thanks for fixing.

@severak severak closed this as completed Jun 7, 2021
truj added a commit that referenced this issue May 5, 2022
- added compact option to switch the note length without a note/chord/rest
- bugfix: shift didn't work for compact syntax with options
- bugfix: added instrument definition check for compact commands
- rewrite of example songs using compact syntax
- #71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug windows windows-related problems
Projects
None yet
Development

No branches or pull requests

2 participants