This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Consume gasRefund From Potential ethereumjs-vm Addition #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure whether it is correct to account for the gas refund in eth_estimateGas. See ethereum/interfaces#8 for (unresolved) discussion on the ambiguity of this RPC method. |
|
Calling this one blocked for now for similar reasons to #75. |
|
Being closed in favor of #141 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes case 1 in #26, but will require the merging of PR ethereumjs/ethereumjs-monorepo#284 before fixed.
This PR adds the gasRefund to the estimated gas call. This can be merged prior to ethereumjs/ethereumjs-monorepo#284 being merged, but may be fruitless to do so until ethereumjs/ethereumjs-monorepo#284 is merged to maintain cohesion and ensuring the problem does end up fixing #26.
More discussion can be found on #26 and ethereumjs/ethereumjs-monorepo#283