This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 686
feat: add support for additional methods used by js-lotus-client-workshop #718
Closed
mikeseese
wants to merge
3
commits into
fix/filecoin-storagedealstates-update
from
fix/filecoin-support-lotus-client-workshop
Closed
feat: add support for additional methods used by js-lotus-client-workshop #718
mikeseese
wants to merge
3
commits into
fix/filecoin-storagedealstates-update
from
fix/filecoin-support-lotus-client-workshop
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no change requests, just comments.
}, | ||
sectorSize: { | ||
serializedName: "SectorSize", | ||
defaultValue: 18446744073709551615n // max from https://bit.ly/2XJItAg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(2n**64n) - 1n
, if you cared to compress this giant number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copy-pasted this from the spec; I'd rather have a copied number than a grokable one here
5954ac6
to
2bb0849
Compare
29dbc2b
to
4d78760
Compare
2bb0849
to
b325d07
Compare
3fa1232
to
d3a3cae
Compare
b325d07
to
abcd8e1
Compare
d3a3cae
to
abe4ed9
Compare
abcd8e1
to
bb83c01
Compare
abe4ed9
to
905e98c
Compare
We're postponing these reviews until later |
This was referenced Mar 4, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #693:
Filecoin.Version
methodFilecoin.ActorAddress
methodFilcoin.StateMinorInfo
method