Skip to content
This repository has been archived by the owner on Sep 27, 2019. It is now read-only.

Fix syncAlways option use in blocksSaga #94

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

mnaamani
Copy link
Contributor

Solves #93

  • Correctly pass syncAlways argument
  • Iterate over drizzle.contracts object with Object.keys() instead of map
  • Add all missing import from redux-saga/effects

@mnaamani
Copy link
Contributor Author

@DiscRiskandBisque should we include the dist/drizzle.js and package-lock.json in the PR?
I'm assuming we shouldn't and that step will be done in a seperate PR by maintainers when merging into master and prior to publishing to npm?

@OnlyOneJMJQ
Copy link
Contributor

OnlyOneJMJQ commented Jul 3, 2018

@mnaamani Thank you for this! No need to include the build--you're correct that we'll run the build command before pushing to develop/master.

A little more background on this decision (it is a controversial one 🙂): In the interim before moving toward a more traditional release structure (akin to canary -> beta -> release -> lts) we're using the build folder as a quick nightly.

@OnlyOneJMJQ OnlyOneJMJQ merged commit e827f4d into trufflesuite:develop Jul 3, 2018
@mnaamani mnaamani mentioned this pull request Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants