This repository has been archived by the owner on Sep 27, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
WEB3_FAILED
action is never being dispatched. This is because when injected web3 is missing, the error is caught ininitializeDrizzle
instead ofcallInitializeWeb3
. This is causingweb3.status
in the redux state to be'initialized'
.Steps to reproduce
Initialize drizzle without metamask enabled.
Changes included in PR
callInitializeWeb3
is removed in favor of wrapping the contents ofinitializeWeb3
in a try...catchstore.dispatch({type: 'WEB3_FAILED', error})
is replaced withyield put({type: 'WEB3_FAILED', error})
web3
is asserted ininitializeDrizzle