Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update log for large s3 file #3835

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Update log for large s3 file #3835

merged 2 commits into from
Jan 10, 2025

Conversation

0x1
Copy link
Contributor

@0x1 0x1 commented Jan 9, 2025

Description:

Updating s3 large file log. Adding the file size, max file size, and file name (for further investigations if needed)

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@0x1 0x1 requested review from a team as code owners January 9, 2025 20:45
ahrav
ahrav reviewed Jan 9, 2025
View reviewed changes
pkg/sources/s3/s3.go Outdated Show resolved Hide resolved
rosecodym
rosecodym approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@rosecodym rosecodym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@0x1 0x1 merged commit 81d5859 into main Jan 10, 2025
13 checks passed
@0x1 0x1 deleted the scan-31-improve-logging branch January 10, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrav ahrav ahrav left review comments

@rosecodym rosecodym rosecodym approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x1 @rosecodym @ahrav