updated and fixed typeform detectors #3769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashifkhan0771
commented
Dec 12, 2024
| @@ -86,40 +89,6 @@ func TestTypeform_FromChunk(t *testing.T) { | |||
| wantErr: false, | |||
| wantVerificationErr: false, | |||
| }, | |||
| { | |||
| name: "found, would be verified if not for timeout", | |||
There was a problem hiding this comment.
Even with 1 Microsecond timeout this test case was failing with no error 😄 (🥲) So I removed them.
kashifkhan0771
force-pushed
the
update/typeform-detectors
branch
from
c5b0d9d to
ec892be
Compare
ahrav
approved these changes
Dec 12, 2024
kashifkhan0771
force-pushed
the
update/typeform-detectors
branch
from
3fe6f2b to
d4cc844
Compare
ahrav
approved these changes
Dec 12, 2024
rgmz
pushed a commit
to rgmz/trufflehog
that referenced
this pull request
Dec 12, 2024
* updated and fixed typeform detectors * fixed linter issue * added tags back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR improve overall logic of TypeForm detectors and fixes it's integration test cases.
Checklist:
make test-community)?make lintthis requires golangci-lint)?