Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] - Upgrade Archiver dependency #3743

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented Dec 9, 2024

Description:

The author has deprecated the older version of the [archiver library](https://github.com/mholt/archiver) in favor of the new [archives library](https://github.com/mholt/archives), which introduces breaking changes that must be manually addressed.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@ahrav ahrav marked this pull request as ready for review December 9, 2024 01:04
@ahrav ahrav requested review from a team as code owners December 9, 2024 01:04
@ahrav ahrav requested a review from a team December 9, 2024 01:04
Copy link
Collaborator

@rosecodym rosecodym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's nice to get rid of that pin

pkg/handlers/handlers.go Outdated Show resolved Hide resolved
@ahrav ahrav merged commit 166aa83 into main Dec 9, 2024
13 checks passed
@ahrav ahrav deleted the chore-upgrade-archiver-dependency branch December 9, 2024 18:03
rosecodym added a commit that referenced this pull request Dec 31, 2024
This PR cleans up a context.TODO left by #3743.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants