Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated/fixed the function names of pattern tests for detectors n through o #3691

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Updated/fixed the function names of pattern tests for detectors n through o #3691

merged 1 commit into from
Nov 28, 2024

Conversation

nabeelalam
Copy link
Contributor

@nabeelalam nabeelalam commented Nov 28, 2024 •
edited
Loading

This PR fixes the function names in new pattern tests added in this pull-request.

Test function names should now be consistent and include the correct name of the corresponding detector.

Test Output:

image

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@nabeelalam nabeelalam marked this pull request as ready for review November 28, 2024 07:33
@nabeelalam nabeelalam requested review from a team as code owners November 28, 2024 07:33
@ahrav
Copy link
Collaborator

ahrav commented Nov 28, 2024

Thank you!

@ahrav ahrav merged commit fe6773e into trufflesecurity:main Nov 28, 2024
13 checks passed
@blsaccess blsaccess mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrav ahrav ahrav approved these changes

@kashifkhan0771 kashifkhan0771 kashifkhan0771 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nabeelalam @ahrav @kashifkhan0771