Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Opsgenie detector #3608

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Update Opsgenie detector #3608

merged 1 commit into from
Nov 15, 2024

Conversation

rgmz
Copy link
Contributor

@rgmz rgmz commented Nov 15, 2024

Description:

This updates the Opsgenie detector to:

  1. Use tri-state verification
  2. Include relevant information in extraData, if available
  3. Deduplicate matches and filter low-entropy false positives

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@rgmz rgmz requested a review from a team as a code owner November 15, 2024 01:17
ahrav
ahrav approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@ahrav ahrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this updated!

pkg/detectors/opsgenie/opsgenie.go

// Make sure that your group is surrounded in boundary characters such as below to reduce false positives.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😛

@ahrav ahrav merged commit a6e2b99 into trufflesecurity:main Nov 15, 2024
13 checks passed
@rgmz rgmz deleted the feat/update-opsgenie branch November 15, 2024 06:41
@blsaccess blsaccess mentioned this pull request Nov 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrav ahrav ahrav approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgmz @ahrav