-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] - S3 metrics #3577
[feat] - S3 metrics #3577
Conversation
…y/trufflehog into feat-s3-source-resumption
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes seem fine, I'm just a little confused why the metrics collector object is a field of the s3 source instead of a global like our other metrics.
Mainly for testability. I haven’t added the metrics tests yet, but I want to make them testable in a similar way to how I tested the metrics for our cache package here |
375d817
to
fcdd7ab
Compare
Description:
This PR adds metrics for tracking a S3 scan.
Checklist:
make test-community
)?make lint
this requires golangci-lint)?