Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] - S3 metrics #3577

Merged
merged 31 commits into from
Nov 26, 2024
Merged

[feat] - S3 metrics #3577

merged 31 commits into from
Nov 26, 2024

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented Nov 8, 2024

Description:

This PR adds metrics for tracking a S3 scan.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@ahrav ahrav requested review from a team November 8, 2024 22:20
@ahrav ahrav marked this pull request as ready for review November 8, 2024 22:40
@ahrav ahrav requested a review from a team as a code owner November 8, 2024 22:40
Copy link
Collaborator

@mcastorina mcastorina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem fine, I'm just a little confused why the metrics collector object is a field of the s3 source instead of a global like our other metrics.

pkg/sources/s3/metrics.go Outdated Show resolved Hide resolved
pkg/sources/s3/metrics.go Outdated Show resolved Hide resolved
@ahrav
Copy link
Collaborator Author

ahrav commented Nov 15, 2024

The changes seem fine, I'm just a little confused why the metrics collector object is a field of the s3 source instead of a global like our other metrics.

Mainly for testability. I haven’t added the metrics tests yet, but I want to make them testable in a similar way to how I tested the metrics for our cache package here

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2024

CLA assistant check
All committers have signed the CLA.

Base automatically changed from s3-progress-tracker to main November 22, 2024 21:33
@ahrav ahrav requested a review from a team as a code owner November 22, 2024 21:33
@ahrav ahrav merged commit 7b3d98d into main Nov 26, 2024
13 checks passed
@ahrav ahrav deleted the s3-metrics branch November 26, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants