Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] - add config option for s3 resumption #3563

Merged
merged 1 commit into from
Nov 7, 2024
Merged

[feat] - add config option for s3 resumption #3563

merged 1 commit into from
Nov 7, 2024

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented Nov 5, 2024

Description:

This PR adds a temporary resumption option to the s3 source.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@ahrav ahrav marked this pull request as ready for review November 6, 2024 00:38
@ahrav ahrav requested review from a team as code owners November 6, 2024 00:38
mcastorina
mcastorina reviewed Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@mcastorina mcastorina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a config option?

@ahrav ahrav merged commit c345df9 into main Nov 7, 2024
13 checks passed
@ahrav ahrav deleted the s3-resumption-config branch November 7, 2024 02:30
@blsaccess blsaccess mentioned this pull request Nov 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcastorina mcastorina mcastorina left review comments

@rosecodym rosecodym rosecodym approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahrav @mcastorina @rosecodym