[chore] - minor cleanup S3 source #3554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosecodym
approved these changes
Nov 4, 2024
pkg/sources/s3/s3.go
Outdated
|
|
||
| if common.IsDone(ctx) { | ||
| return | ||
| } | ||
|
|
||
| s.SetProgressComplete(i, len(bucketsToScan), fmt.Sprintf("Bucket: %s", bucket), "") | ||
| logger.V(3).Info("Scanning bucket") | ||
| s.SetProgressComplete(i, len(bucketsToScan), "Bucket: "+bucket, "") |
There was a problem hiding this comment.
I have no opinion about your other stylistic changes, but this one took me a second to understand. Do you have a strong objection to retaining fmt.Sprintf here?
There was a problem hiding this comment.
Happy to change it back. I'll also consider disabling perfsprintf from my linter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR resolves linter issues and removes the logger from the S3 Source struct, switching to using the context for logging instead.
Checklist:
make test-community)?make lintthis requires golangci-lint)?