Extend algoliaadminkey with additional checks
#3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0x2b3bfa0 that blog is from 2020. Did you test this locally? Do you have a screenshot of the integration test passing with a valid credential? |
This comment was marked as outdated.
This comment was marked as outdated.
|
@zricethezav, locally everything seems to work "fine" now; I wonder if continuous integration will agree. 🤞🏼 |
2 tasks
0x2b3bfa0
changed the title
algoliaadminkey with ACL checksalgoliaadminkey with additional checks
0x2b3bfa0
force-pushed
the
0x2b3bfa0-patch-1
branch
from
61a2c21 to
4dc3365
Compare
0x2b3bfa0
commented
Oct 21, 2024
|
@zricethezav, I've consolidated #3458 into this pull request and made sure all tests pass. |
zricethezav
approved these changes
Oct 24, 2024
abmussani
added a commit
to abmussani/trufflehog
that referenced
this pull request
Oct 30, 2024
* main: (76 commits) update aws descriptions (trufflesecurity#3529) enforce timeout on circleci test (trufflesecurity#3528) rm snifftest (trufflesecurity#3527) Redact more source credentials (trufflesecurity#3526) Create global log redaction capability (trufflesecurity#3522) Adding basic "what is trufflehog" to the readme (trufflesecurity#3514) Handle custom detector response and include in extra data (trufflesecurity#3411) fix: fixed validation logic for `calendarific` (trufflesecurity#3480) fix(deps): update github.com/tailscale/depaware digest to 3d7f3b3 (trufflesecurity#3518) Move DecoderType into ResultWithMetadata trufflesecurity#3502 Addeded 403 account block status code handling for gitlab (trufflesecurity#3471) updated gcpapplicationdefaultcredentials detector results with RawV2 (trufflesecurity#3499) fix(deps): update module github.com/brianvoe/gofakeit/v7 to v7.1.1 (trufflesecurity#3512) fix(deps): update module github.com/schollz/progressbar/v3 to v3.17.0 (trufflesecurity#3510) fix(deps): update module cloud.google.com/go/secretmanager to v1.14.2 (trufflesecurity#3498) Adds a logging section in the contributing guidelines (trufflesecurity#3509) fix: fixed verifcation pattern logic for `bulksms` (trufflesecurity#3478) Extend `algoliaadminkey` with additional checks (trufflesecurity#3459) fix(deps): update module google.golang.org/api to v0.203.0 (trufflesecurity#3497) fix: added correct api endpoint for verification & logic for Aeroworkflow (trufflesecurity#3435) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds verification for other kinds of sensitive Algolia API keys apart from Admin keys, as per https://www.secjuice.com/api-misconfiguration-data-breach.
This pull reques also enhances the detection of Algolia keys by looking also for Algolia DocSearch keywords and option names on the official libraries (example).
Checklist
make test-community)?make lintthis requires golangci-lint)?