[analyze] Add analyzer interface for Shopify #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcastorina
approved these changes
Aug 23, 2024
abmussani
force-pushed
the
impl-data-model-shopify
branch
from
2bdf69c to
1b15793
Compare
mcastorina
reviewed
Sep 5, 2024
|
|
||
| resource := &analyzers.Resource{ | ||
| Name: info.ShopInfo.Shop.Name, | ||
| FullyQualifiedName: info.ShopInfo.Shop.Email, |
There was a problem hiding this comment.
It seems plausible that the email can be reused across shops. Maybe we can use the domain instead? There's a lot of information in the shop.json API to choose from.
Comment on lines
4
to
33
| { | ||
| "Resource":{ | ||
| "Name":"My Store", | ||
| "FullyQualifiedName":"[email protected]", | ||
| "Type":"shop", | ||
| "Metadata":{ | ||
| "created_at":"2024-08-16T17:16:17+05:00" | ||
| }, | ||
| "Parent":null | ||
| }, | ||
| "Permission":{ | ||
| "Value":"Read", | ||
| "Parent":null | ||
| } | ||
| }, | ||
| { | ||
| "Resource":{ | ||
| "Name":"My Store", | ||
| "FullyQualifiedName":"[email protected]", | ||
| "Type":"shop", | ||
| "Metadata":{ | ||
| "created_at":"2024-08-16T17:16:17+05:00" | ||
| }, | ||
| "Parent":null | ||
| }, | ||
| "Permission":{ | ||
| "Value":"Read", | ||
| "Parent":null | ||
| } | ||
| }, |
There was a problem hiding this comment.
These bindings look exactly the same. Are we setting the permission correctly?
There was a problem hiding this comment.
It's also just "Read" which makes me think we're not using the generated permission values.
There was a problem hiding this comment.
thank you for pointing it out. I noted that permissions where being assigned to shop resource instead of categories. Fixed this issue.
abmussani
force-pushed
the
impl-data-model-shopify
branch
from
da3b527 to
273e8db
Compare
mcastorina
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements the analyzer interface for shopify.
Checklist:
make test-community)?make lintthis requires golangci-lint)?