Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Voiceflow detector #1900

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Add Voiceflow detector #1900

merged 1 commit into from
Oct 18, 2023

Conversation

rgmz
Copy link
Contributor

@rgmz rgmz commented Oct 18, 2023 •
edited
Loading

Description:

This adds a detector for https://voiceflow.com Dialog Manager (VF.DM.xxx.yyy) tokens. A valid token can be created by signing up for a Voiceflow account and following these instructions.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@rgmz rgmz requested a review from a team as a code owner October 18, 2023 01:21
@rgmz rgmz force-pushed the feat/voiceflow-detector branch from 88736ab to 12ff9aa Compare October 18, 2023 01:23
@zricethezav zricethezav added the Hacktoberfest-Detector-Competition-New Apply this label if you are adding a new detector for the detector competition label Oct 18, 2023
@rgmz rgmz force-pushed the feat/voiceflow-detector branch from 12ff9aa to 4840fd3 Compare October 18, 2023 01:36
@rgmz rgmz marked this pull request as draft October 18, 2023 01:36
@rgmz rgmz marked this pull request as ready for review October 18, 2023 13:52
@zricethezav
Copy link
Collaborator

@rgmz same goes for this PR, do you have a screenshot of the tests passing?

@rgmz rgmz force-pushed the feat/voiceflow-detector branch from 4840fd3 to ded86aa Compare October 18, 2023 16:20
@rgmz
Copy link
Contributor Author

rgmz commented Oct 18, 2023

@rgmz same goes for this PR, do you have a screenshot of the tests passing?

image

On that note, I should probably rewrite my tests to fold TestVoiceflow_Pattern cases into TestVoiceflow_FromChunk. The former was copied from elsewhere and doesn't seem necessary in this case.

@rgmz rgmz force-pushed the feat/voiceflow-detector branch from ded86aa to de6702c Compare October 18, 2023 16:23
@zricethezav
Copy link
Collaborator

Thanks for including the screenshot!

@rgmz

On that note, I should probably rewrite my tests to fold TestVoiceflow_Pattern cases into TestVoiceflow_FromChunk. The former was copied from elsewhere and doesn't seem necessary in this case.

Eh, I don't think that's necessary. TestVoiceflow_Pattern is a nice way to test the regex without calling out to the service. Hell, we might include something like that in the default template in the future.

@zricethezav zricethezav merged commit b57b1c1 into trufflesecurity:main Oct 18, 2023
Phoenix591 pushed a commit to Phoenix591/trufflehog that referenced this pull request Oct 27, 2023
@rgmz @Phoenix591
feat(voiceflow): basic detector (trufflesecurity#1900)
6a4b569
@rgmz rgmz deleted the feat/voiceflow-detector branch December 14, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zricethezav zricethezav zricethezav approved these changes

Assignees
No one assigned
Labels
Hacktoberfest-Detector-Competition-New Apply this label if you are adding a new detector for the detector competition
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgmz @zricethezav