[MongoDB] Detect CosmoDB access keys #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rgmz I don't have an issue with this PR per se, but one thought I had, which other team members may take issue with is, should this be a separate detector? From my understanding CosmoDB is an Azure offering by Microsoft which treats a CosmoDB as a MongoDB. This is a weird one and I don't really have a strong opinion either way. |
|
Given that CosmoDB for MongoDB supports the MongoDB wire protocol, maintaining a separate detector would probably be unnecessary work (e.g., changes to mongodb would have to be synced). |
rgmz
force-pushed
the
fix/mongodb-regex
branch
2 times, most recently
from
cd4de13 to
382f478
Compare
zricethezav
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current pattern does not detect Azure CosmoDB Access Keys, which are 88 characters long.
Random example pulled from GitHub:
https://github.com/MichelliBrito/agendalive/blob/e74b7d74cc28140f77e22af1ba372a813dc99aa4/src/main/resources/application.properties#L2
I would recommend generating a live secret and adding that to the test bank, if possible.