NAS-132988 / 24.10.2 / Do not retrieve hidden zpool properties (by usaleem-ix) #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zprop_iter provides an interface to iterate over all available zpool properties. To iterate over hidden zpool properties, show_all parameter should be set to true. Recently, dedupcached property was added as part of fast dedup support in ZFS. This property is quite expensive since it needs to calculate the total size of dedup table loaded into the ARC. This commit updates the show_all parameter passed to zprop_iter, and sets it to False, since we don't want to retrieve the dedupcached property. All other hidden zpool properties will not be retrieved either as part of zprop_iter. These properties include name, tname, maxblocksize, maxdnodesize, dedupditto and dedupcached. Signed-off-by: Umer Saleem <[email protected]> (cherry picked from commit 8c66fcc)
yocalebo
approved these changes
Jan 14, 2025
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zprop_iterprovides an interface to iterate over all available zpool properties. To iterate over hidden zpool properties,show_allparameter should be set to true.Recently,
dedupcachedproperty was added as part of fast dedup support in ZFS. This property is quite expensive since it needs to calculate the total size of dedup table loaded into the ARC.This commit updates the
show_allparameter passed tozprop_iter, and sets it toFalse, since we don't want to retrieve thededupcachedproperty. All other hidden zpool properties will not be retrieved either as part ofzprop_iter. These properties includename,tname,maxblocksize,maxdnodesize,dedupdittoanddedupcached.Original PR: #293
Jira URL: https://ixsystems.atlassian.net/browse/NAS-132988