Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133001 / 25.04 / Add flag to delete extents when removing a target #15226

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

bmeagherix
Copy link
Contributor

Add an additional optional delete_extents parameter to iscsi.target.delete

Add iSCSI unit test test__target_delete_extents


Passing CI run here.

@bugclerk bugclerk changed the title NAS-133001 NAS-133001 / 25.04 / NAS-133001 Dec 17, 2024
@bugclerk
Copy link
Contributor

@bmeagherix bmeagherix changed the title NAS-133001 / 25.04 / NAS-133001 NAS-133001 / 25.04 / Add flag to delete extents when removing a target Dec 17, 2024
@bmeagherix bmeagherix requested a review from a team December 17, 2024 22:55
@bmeagherix bmeagherix merged commit 59fb14f into master Dec 18, 2024
2 checks passed
@bmeagherix bmeagherix deleted the NAS-133001 branch December 18, 2024 14:17
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants