Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-132961 / 25.04 / Move enclosure label to its own file #15215

Merged
merged 2 commits into from
Dec 18, 2024
Merged

NAS-132961 / 25.04 / Move enclosure label to its own file #15215

merged 2 commits into from
Dec 18, 2024

Conversation

themylogin
Copy link
Contributor

No description provided.

@themylogin themylogin requested a review from yocalebo December 16, 2024 13:01
@themylogin
Copy link
Contributor Author

time 1:00

@bugclerk bugclerk changed the title Move enclosure label to its own file NAS-132961 / 25.04 / Move enclosure label to its own file Dec 16, 2024
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-132961

yocalebo
yocalebo requested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@yocalebo yocalebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still naming the plugin namespace enclosure. Please rename the class to EnclosureLabelService and explicitly define namespace = "enclosure.label"

@themylogin
Copy link
Contributor Author

This is still naming the plugin namespace enclosure. Please rename the class to EnclosureLabelService and explicitly define namespace = "enclosure.label"

So, API change? Can we simplify the API then?

@yocalebo
Copy link
Contributor

This is still naming the plugin namespace enclosure. Please rename the class to EnclosureLabelService and explicitly define namespace = "enclosure.label"

So, API change? Can we simplify the API then?

Yes absolutely, let's simplify as much as possible.

@themylogin
Copy link
Contributor Author

WebUI PR truenas/webui#11200

@themylogin themylogin requested a review from yocalebo December 17, 2024 20:34
@themylogin themylogin merged commit 9da3a5b into master Dec 18, 2024
2 checks passed
@themylogin themylogin deleted the NAS-132961 branch December 18, 2024 23:01
@themylogin
Copy link
Contributor Author

time 1:30

@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 18, 2024
@bugclerk
Copy link
Contributor

Time tracking added.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yocalebo yocalebo yocalebo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@themylogin @bugclerk @yocalebo