NAS-132946 / 25.04 / Complete VM support in virt plugin #15151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
Qubad786
force-pushed
the
mrehan/virt-vm-support
branch
7 times, most recently
from
7743d57 to
7f48baa
Compare
Qubad786
force-pushed
the
mrehan/virt-vm-support
branch
from
7f48baa to
e16d7d1
Compare
Qubad786
force-pushed
the
mrehan/virt-vm-support
branch
from
e16d7d1 to
d8d0bc6
Compare
william-gr
reviewed
Dec 16, 2024
Qubad786
force-pushed
the
mrehan/virt-vm-support
branch
from
d8d0bc6 to
dd96008
Compare
Qubad786
force-pushed
the
mrehan/virt-vm-support
branch
2 times, most recently
from
d41e676 to
7cdfa15
Compare
Qubad786
force-pushed
the
mrehan/virt-vm-support
branch
from
7cdfa15 to
698ca9b
Compare
Qubad786
force-pushed
the
mrehan/virt-vm-support
branch
from
698ca9b to
d2355e4
Compare
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
VM support has been added to virt plugin which allows specifying VM based images to be used for VM creation or not using a source image at VM creation and later using an ISO to bootstrap the VM.
For an ISO to be used with a VM, the iso needs to be imported as an incus volume and then that incus volume attached to the virt instance. A CRUD for virt volumes has been added and the ability to import iso as a virt volume which then can later be attached to virt VM instance. Virt volumes are currently only supported for VMs.
While we are here, validation has been improved and some bug fixes have been done wrt USB/GPU devices.