Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131305 / 24.10.1 / fix MINI 3.0 X (vers 1.0) drive mapping (by yocalebo) #14659

Closed
wants to merge 1 commit into from

Conversation

bugclerk
Copy link
Contributor

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x fdc0b89fe2b07d48cd1795c0053e2d160598a61d

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x 9993ac1227e89e59a74940c901d95cd7cce01af6

We do not have a MINI 3.0 X version 1.0 internally to test these changes on, however, we do have a non-version 1.0 which is essentially the same device just cabled so slightly differently.

I have added the mapping based on physically identifying drives on the non-version 1.0 and working backwards from there. Most of the changes here are related to 2 changes:

  1. updating docstrings to reflect reality
  2. removing the need to pass the dmi object around. Instead I use our dedicated ixhardware module (which does the exact same thing but provides me the ability to access the system_version buffer which is needed for the mini 3.0 x version 1.0 platform.

I have tested these changes on (with no regressions):

  1. m60 with 12x ES102's connected
  2. mini 3.0 x (NON version 1.0)
  3. random hardware that we don't sell

Original PR: #14657
Jira URL: https://ixsystems.atlassian.net/browse/NAS-131305

@yocalebo yocalebo closed this Oct 11, 2024
@yocalebo yocalebo deleted the NAS-131305-24.10.1 branch October 11, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants