NAS-131733 / 25.04 / Fix SMB create and directory mask defaults #14655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
This is a regression that slipped into large refactor effort to remove clustering vestiges in Electric Eel. The values for default create mask and directory mask became more restrictive than in previous TrueNAS versions. This commit resets them to old defaults for the directory mask (775) but a slightly more restrictive default for files (664) since execute is generally not desired for newly created files. Tests validating new defaults is also added. Generally, these values are not used when SMB shares are created with our recommended default configuration (using NFSv4 ACLs with a restricted aclmode) and so impact on userbase during BETA / RC cycles was minimal.
anodos325
force-pushed
the
fix-default-smb-masks
branch
from
1356f94 to
7375aeb
Compare
yocalebo
approved these changes
Oct 11, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression that slipped into large refactor effort to remove clustering vestiges in Electric Eel. The values for default create mask and directory mask became more restrictive than in previous TrueNAS SCALE versions. This commit resets them to old defaults for the directory mask (775) but a slightly more restrictive default for files (664) since execute is generally not desired for newly created files. Tests validating new defaults is also added.
Generally, these values are not used when SMB shares are created with our recommended default configuration (using NFSv4 ACLs with a restricted aclmode) and so impact on userbase during BETA / RC cycles was minimal.