NAS-131717 / 24.10.0 / fix r50 series nvme enclosure maps (by yocalebo) #14652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit bedc0c1)
yocalebo
approved these changes
Oct 10, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked with platform team on an internal R50BM that was experiencing enclosure problems. Found that I had copy and pasted the rear nvme drive bay logic from the M30 which doesn't apply to the R50 series. The m-series have 24 front drive bays and 4 rear nvmes while the R50 series has 48 top loaded drives plus 2,3 and 4 rear nvme drives. This fixes the typo and I confirmed fixes the issue that was being experienced.
Original PR: #14651
Jira URL: https://ixsystems.atlassian.net/browse/NAS-131717