NAS-131233 / 25.04 / Update to test for FIPS 3.0.9 #14629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
sonicaj
reviewed
Oct 8, 2024
yocalebo
reviewed
Oct 11, 2024
aiden3c
force-pushed
the
NAS-131233
branch
3 times, most recently
from
1d033c5 to
560f799
Compare
aiden3c
force-pushed
the
NAS-131233
branch
2 times, most recently
from
7e513ee to
6bcd5aa
Compare
|
@sonicaj just pinging for review's sake |
sonicaj
reviewed
Oct 17, 2024
| @pytest.mark.skipif(not ha, reason='Test only valid for HA') | ||
| def test_fips_version(): | ||
| # The reason we have a set of commands in a payload is because of some annoying FIPS technicalities. | ||
| # Basically, when FIPS is enabled, we can't use SSH because the SSH key used by root isn't using a FIPS provided algorithm. (this might need to be investigated further) |
There was a problem hiding this comment.
Btw you should be able to pull that off with -c aes128-ctr iirc flag (not saying it's necessary but just sharing here)
sonicaj
approved these changes
Oct 18, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the test for verifying our FIPS version, as well as checking that middleware reports the proper reboot reasons upon FIPS being enabled.
Enabling/disabling FIPS takes some time, so I also had to up the SSH command timeout through an optional argument.
This is paired with this PR to actually apply the new FIPS changes.
Passing tests as always