NAS-131033 / 25.04 / API test_mail.test_config_settings regression #14440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is generally good practice to restore the system's state at the end of a test, in this case it was not allowed since the fields
fromemail
and others begin as empty strings and validation preventsmail.update
from restoringfromemail
to an empty string.See this test for clarification.
Problematic validation:
middleware/src/middlewared/middlewared/plugins/mail.py
Line 167 in 2da0e2d