Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131033 / 25.04 / API test_mail.test_config_settings regression #14440

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

creatorcary
Copy link
Contributor

@creatorcary creatorcary commented Sep 6, 2024

While it is generally good practice to restore the system's state at the end of a test, in this case it was not allowed since the fields fromemail and others begin as empty strings and validation prevents mail.update from restoring fromemail to an empty string.

See this test for clarification.

Problematic validation:

@bugclerk
Copy link
Contributor

bugclerk commented Sep 6, 2024

@bugclerk bugclerk changed the title API test_mail.test_config_settings regression NAS-131033 / 25.04 / API test_mail.test_config_settings regression Sep 6, 2024
@creatorcary creatorcary merged commit a7c5455 into master Sep 6, 2024
2 of 3 checks passed
@creatorcary creatorcary deleted the NAS-131033 branch September 6, 2024 16:10
@bugclerk
Copy link
Contributor

bugclerk commented Sep 6, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants