Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130930 / 25.04 / remove useless test #14439

Merged
merged 1 commit into from
Sep 6, 2024
Merged

NAS-130930 / 25.04 / remove useless test #14439

merged 1 commit into from
Sep 6, 2024

Conversation

yocalebo
Copy link
Contributor

@yocalebo yocalebo commented Sep 6, 2024

This is an old test that hasn't run in many years. It only gets executed if runtest.py sets the update boolean which only gets set if someone passes that flag to runtest.py. We don't do that and haven't done that since we took over maintaining the API test suite. Remove this test file.

@yocalebo yocalebo requested a review from a team September 6, 2024 13:43
@bugclerk
Copy link
Contributor

bugclerk commented Sep 6, 2024

@bugclerk bugclerk changed the title remove useless test NAS-130930 / 25.04 / remove useless test Sep 6, 2024
@yocalebo yocalebo merged commit 5ae77d3 into master Sep 6, 2024
2 of 3 checks passed
@yocalebo yocalebo deleted the NAS-130930 branch September 6, 2024 14:02
@bugclerk
Copy link
Contributor

bugclerk commented Sep 6, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants