NAS-131017 / 25.04 / Fix zpool.status regression #14427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
yocalebo
requested changes
Sep 5, 2024
There was a problem hiding this comment.
This doesn't fix anything. Please see the numerous test failures here: http://jenkins.eng.ixsystems.net:8080/job/tests/job/api_tests/443/testReport/junit/api2/. All of those are failing because disk.get_unused is crashing with a KeyError.
mgrimesix
approved these changes
Sep 5, 2024
|
Removed accidental approval. |
Qubad786
force-pushed
the
mrehan/fix-zpool-status-test
branch
from
cde66fc to
a099b7b
Compare
yocalebo
changed the title
Qubad786
force-pushed
the
mrehan/fix-zpool-status-test
branch
from
a099b7b to
7a8f040
Compare
yocalebo
approved these changes
Sep 6, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Integration test for
zpool.statuswas failing earlier because we were not usingfilesystem.listdirto list disks and hence the relevant mapping could not be generated which eventually led to failure of the test.