Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130934 / 25.04 / remove unnecessary test (test_210) #14424

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

yocalebo
Copy link
Contributor

@yocalebo yocalebo commented Sep 5, 2024

This test is verifying functionality that is extensively tested in other files (test_035, test_036). Discussed with @anodos325 that this can be removed. However, we do need to add a test to test the delete_users option to group.delete as that isn't currently being tested. That will be done in another PR.

@yocalebo yocalebo requested a review from a team September 5, 2024 13:21
@bugclerk bugclerk changed the title remove unnecessary test (test_210) NAS-130934 / 25.04 / remove unnecessary test (test_210) Sep 5, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Sep 5, 2024

@yocalebo yocalebo merged commit c7cbc04 into master Sep 5, 2024
2 of 3 checks passed
@yocalebo yocalebo deleted the NAS-130934 branch September 5, 2024 13:24
@bugclerk
Copy link
Contributor

bugclerk commented Sep 5, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants