-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-130981 / 25.04 / Allow specifying custom address pools for docker service (by sonicaj) #14410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 6e05c40)
(cherry picked from commit 7060a0c)
(cherry picked from commit d5054b2)
(cherry picked from commit 4685561)
(cherry picked from commit 7763552)
(cherry picked from commit 793ef17)
(cherry picked from commit 629a0b5)
(cherry picked from commit ec67484)
(cherry picked from commit 52919c6)
(cherry picked from commit 1c41b42)
(cherry picked from commit 17b939c)
(cherry picked from commit 2434e80)
sonicaj
approved these changes
Sep 3, 2024
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds changes to make address pools of docker service configurable so user can choose whatever address pools he/she wishes to consume for docker containers.
Original PR: #14408
Jira URL: https://ixsystems.atlassian.net/browse/NAS-130981