NAS-130890 / 24.10-RC.1 / Fix UPS events (by bmeagherix) #14409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmeagherix
approved these changes
Sep 3, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change (PR #14319) changed the default
lock_queue_sizefromNoneto5.However,
ups.dismiss_alertswas callingalert.oneshot_delete6 times. Further, shortly afterwards it was callingalert.oneshot_createwhich uses the same lock. Depending upon timing, this could result in thealert.oneshot_createnot running.Rectify(/avoid) by adding a
alert.oneshot_bulk_delete, so thatups.dismiss_alertsonly needs to make a single call. (This has the added benefit of being slightly more efficient.)(Choosing backport-24.10-RC.1 because the above mentioned PR was also backported there.)
Original PR: #14391
Jira URL: https://ixsystems.atlassian.net/browse/NAS-130890