NAS-130979 / 25.04 / Support legacy API #14405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themylogin
force-pushed
the
legacy-api
branch
from
0fe3f5e to
97fe63a
Compare
themylogin
force-pushed
the
legacy-api
branch
from
97fe63a to
5f1f83d
Compare
yocalebo
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Really cool, please wait for @anodos325 review before merge.
anodos325
approved these changes
Sep 10, 2024
|
This PR has been merged and conversations have been locked. |
|
time 40:00 |
|
Time tracking added. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue implementing NEP 046 (Versioned API).
This code adds
/api/vXX.XX.Xendpoints for all API versions we have and provides data conversion routines between those versions.There are no integration tests because we don't yet have two different API versions. The code is extensively covered by unit-tests. The integration testing was performed by adding a fake 24.10.0 API and ensuring everything works smoothly. Fake API code is not present in this PR.