Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130907 / 25.04 / Removed REST from test_150_cronjob #14399

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Conversation

aiden3c
Copy link
Contributor

@aiden3c aiden3c commented Sep 3, 2024

Also updated the file name to remove the numbering

@aiden3c aiden3c requested a review from a team September 3, 2024 14:02
@bugclerk bugclerk changed the title Removed REST from test_150_cronjob NAS-130907 / 25.04 / Removed REST from test_150_cronjob Sep 3, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Sep 3, 2024

tests/api2/test_cronjob.py Show resolved Hide resolved
tests/api2/test_cronjob.py Outdated Show resolved Hide resolved
tests/api2/test_cronjob.py Outdated Show resolved Hide resolved
tests/api2/test_cronjob.py Outdated Show resolved Hide resolved
tests/api2/test_cronjob.py Outdated Show resolved Hide resolved
Copy link
Contributor

@yocalebo yocalebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at what this test module does, we can combine all these steps into 2 functions:

  1. create cronjob and wait for it to run, verify it etc
  2. delete cronjob and cleanup TESTFILE

@aiden3c
Copy link
Contributor Author

aiden3c commented Sep 3, 2024

Looking at what this test module does, we can combine all these steps into 2 functions:

I think that I might just make it one so it can use the same cronjob_dict object, but I'll make sure to annotate with comments

@aiden3c aiden3c requested a review from yocalebo September 3, 2024 14:56
@aiden3c aiden3c merged commit ba2e6ff into master Sep 3, 2024
2 of 3 checks passed
@aiden3c aiden3c deleted the NAS-130907 branch September 3, 2024 15:16
@bugclerk
Copy link
Contributor

bugclerk commented Sep 3, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants