NAS-130967 / 24.10-RC.1 / Provide cpu topology extensions to VM if requested #14392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
yocalebo
approved these changes
Sep 3, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Users with AMD CPUs who have SMT (Simultaneous Multithreading) enabled are currently unable to passthrough their CPUs with SMT cores to guest VMs. This is because, by default, SMT support is disabled in libvirtd and requires specific features to be enabled.
Solution:
Add a new field in the VMs configuration that allows users to enable SMT passthrough for their CPUs. When this field is enabled, the relevant features will be added to the CPU XML configuration, ensuring that SMT-enabled CPUs can be properly passed through to the guest if host passthrough is also enabled.