Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-130818 / 25.04 / Add support for FTP roles #14365

Merged
merged 2 commits into from
Aug 28, 2024
Merged

NAS-130818 / 25.04 / Add support for FTP roles #14365

merged 2 commits into from
Aug 28, 2024

Conversation

mgrimesix
Copy link
Contributor

Added management roles for FTP.

  • Added an FTP role CI test
  • Expanded the PR privilege unit test to include FTP.

@mgrimesix
Add support for FTP roles
6096adf 
Includes CI and pytest unit tests
@mgrimesix mgrimesix requested a review from a team August 28, 2024 21:06
@bugclerk bugclerk changed the title Add support for FTP roles NAS-130818 / 25.04 / Add support for FTP roles Aug 28, 2024
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-130818

@mgrimesix mgrimesix merged commit bb77f55 into master Aug 28, 2024
2 of 3 checks passed
@mgrimesix mgrimesix deleted the NAS-130818 branch August 28, 2024 22:01
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmeagherix bmeagherix bmeagherix approved these changes

Assignees
No one assigned
Labels
no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgrimesix @bugclerk @bmeagherix