NAS-130653 / 25.04 / Updated debug generate lock queue size

[aiden3c]

Adding this limit stops people from spamming debug generation, as most of the time just one job is required.

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-130653

[themylogin]

What will happen with the subsequent request in the UI?

[mgrimesix]

Could we get a brief description on what issue this is addressing?

[aiden3c]

What will happen with the subsequent request in the UI?

If we're at the limit of the queue, every subsequent result in the UI takes the same job. One issue with this actually is that the download url given is "one time use only" so those extra calls fail. This is if the debug job specifically is limited, if debug_generate is limited then it effectively does nothing as debug is what's called from the UI.

Thinking about the best way to go about this, maybe just reject subsequent calls from the UI entirely?

[themylogin]

What will happen with the subsequent request in the UI?

If we're at the limit of the queue, every subsequent result in the UI takes the same job. One issue with this actually is that the download url given is "one time use only" so those extra calls fail. This is if the debug job specifically is limited, if debug_generate is limited then it effectively does nothing as debug is what's called from the UI.

Thinking about the best way to go about this, maybe just reject subsequent calls from the UI entirely?

So how will the UI behave if we merge this changes? If I request a debug while a debug is already being gathered, will both UI tabs just download me the same file?

[aiden3c]

It'll try to, but after the file is downloaded the link expires. The other UI tab that tries to use that link returns with

[themylogin]

@aiden3c does the double click lead to the same behavior? We need to resolve this somehow. I would say, we refuse this type of request on our side (need modifications in core.download), and UI fix their double request issue.

[themylogin]

@yocalebo @anodos325 I found no way to double-click the "Save debug" button in the UI. It first opens an "proceed?" dialog, and even if I do double click on "yes" button, only one job is started.

If I open another tab and start the debug generation there, it displays the new error correctly:

Looks like we don't need to do anything on the UI side?

[themylogin]

time 1:30

[themylogin]

http://jenkins.eng.ixsystems.net:8080/job/master/job/custom/473/

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.