NAS-127511 / 25.04 / Fix zpool status for reporting used spare disks correctly #14262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
|
Can we have integration tests for this? |
yocalebo
requested changes
Sep 3, 2024
There was a problem hiding this comment.
zpool status will resolve the vdev devices so we need to remove the resolve_* methods accordingly.
If real_paths is true, we can use -PL otherwise, we can just use -P.
-P will give full path to device (i.e. /dev/disk/by-partuuid/**)
-PL will give full path to real device (i.e. /dev/sda1)
yocalebo
approved these changes
Sep 3, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
zpool.statuswas not properly reporting path for disk properly when a spare had replaced a data disk.Solution
We are now using
zpool statusfor retrieving serialized information about the zpool so we can properly account for disk path being reported for spare based disks and that is much better optimized for a system with large number of disks as compared to py-libzfs.