NAS-130390 / 25.04 / Move discovery auth from per-portal to system-wide (by bmeagherix) #14212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Perform database migration - Generate alerts from migration if appropriate. Uses keyvalue - Add new iscsi.discoveryauth.* APIs - Stub out auth aspect of iscsi.portal.* APIs, for later removal - Add code to clear ISCSIDiscoveryAuth alerts (cherry picked from commit e001b2c)
(cherry picked from commit 2189137)
bmeagherix
approved these changes
Aug 13, 2024
|
JIRA ticket https://ixsystems.atlassian.net/browse/NAS-130390 is targeted to the following versions which have not received their corresponding PRs: 24.10-RC.1 |
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CORE discovery authentication was tied to portals. This is not the case for SCALE, where it is system-wide.
This PR covers the first step in modifying SCALE to reflect reality. We will continue to re-use the Authorized Access groups which are also used in target auth. Multiple groups can be specified for discovery auth & will be combined, with one caveat ... only a single
peeruser/peersecretcan be in use (for Mutual CHAP). (Actually, this caveat is not new.)Alerts will be generated both on migration and subsequently if multiple mutual CHAP peers are defined. The
keyvalueplugin used to communicate the various alerts generated on DB migration (asmiddlewaredis not running at that point).iscsi.discoveryauth.*APIsiscsi.portal.*APIs, for later removalThis is the 2nd generation of this PR, now being made against
stable/electriceel. (A earlier similar but abandoned PR was #14160)Original PR: #14198
Jira URL: https://ixsystems.atlassian.net/browse/NAS-130390