NAS-130485 / 24.10 / Improve auditing for middleware methods #14158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anodos325
force-pushed
the
improve-auditing
branch
3 times, most recently
from
845c917 to
ec17cce
Compare
bugclerk
changed the title
bmeagherix
approved these changes
Aug 7, 2024
anodos325
force-pushed
the
improve-auditing
branch
from
f69ceba to
4c74f19
Compare
Populate `username` and `address` fields in middleware audit entries based on information from the middleware session. The UI prominently displays the `username` field which is currently hard-coded to root. This commit adds a helper function to generate a username string based on the current authenticated credentials for the session generating the audit entry.
anodos325
force-pushed
the
improve-auditing
branch
from
4c74f19 to
1c396c2
Compare
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Populate
usernameandaddressfields in middleware audit entries based on information from the middleware session.The UI prominently displays the
usernamefield which is currently hard-coded to root. This commit adds a helper function to generate a username string based on the current authenticated credentials for the session generating the audit entry.