NAS-128845 / 24.10 / Do not render all IPv4 addresses in Web UI URLs list if :: is in the listen address list, but 0.0.0.0 is not
#14154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e listen address list, but `0.0.0.0` is not
themylogin
changed the title
0.0.0.0 is not0.0.0.0 is not
bugclerk
changed the title
0.0.0.0 is not0.0.0.0 is not
|
time 1:30 |
Qubad786
approved these changes
Aug 7, 2024
yocalebo
reviewed
Aug 7, 2024
| @@ -288,6 +288,10 @@ async def do_update(self, data): | |||
| if ui_restart_delay is not None: | |||
| await self.middleware.call('system.general.ui_restart', ui_restart_delay) | |||
|
|
|||
| if any(config[k] != new_config[k] for k in ['ui_port', 'ui_httpsport', 'ui_httpsredirect', 'ui_address', | |||
There was a problem hiding this comment.
These types of comprehensions aren't my favorite. Can we make this a traditional for loop, please? Also, need to use tuples for static information like this.
for key in ('ui_port', 'ui_httpsport', 'ui_httpsredirect', 'ui_address', 'ui_v6address'):
if config[key] != new_config[key]:
await self.middleware.call('system.reload_cli')
break
yocalebo
approved these changes
Aug 8, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.