NAS-130440 / 24.10 / fix pool.replace regression (introduced in 026691d39e4711107f40c7d0e8b48bbfc4788e9e) #14151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
|
Passing tests are here: http://jenkins.eng.ixsystems.net:8080/job/master/job/api_tests/1835/ |
aiden3c
approved these changes
Aug 6, 2024
anodos325
approved these changes
Aug 6, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 026691d, a commit was made to also wipe the disk that was being replaced when
pool.replacewas being called. I looked at that ticket but it's still not clear to me why this logic was added. In every possible scenario, it's entirely unnecessary to wipe the disk that is being replaced. Remove that logic and updatepool_replace_diskapi test accordingly. (also improve the test by documenting it as well).