Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130346 / 24.10 / Fix audit messages for SMB shares #14116

Merged
merged 1 commit into from
Jul 31, 2024
Merged

NAS-130346 / 24.10 / Fix audit messages for SMB shares #14116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/middlewared/middlewared/plugins/smb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,7 +819,7 @@ class Config:
),
register=True
),
audit='Create SMB share', audit_extended=lambda data: data['name']
audit='SMB share create', audit_extended=lambda data: data['name']
)
@pass_app(rest=True)
async def do_create(self, app, data):
Expand Down Expand Up @@ -969,7 +969,7 @@ async def apply_share_changes(self, old_is_locked, new_is_locked, oldname, newna
'sharingsmb_update',
('attr', {'update': True})
),
audit='Update SMB share',
audit='SMB share update',
audit_callback=True,
)
@pass_app(rest=True)
Expand Down Expand Up @@ -1073,7 +1073,7 @@ async def do_update(self, app, audit_callback, id_, data):

return await self.get_instance(id_)

@accepts(Int('id'), audit='Delete SMB share', audit_callback=True)
@accepts(Int('id'), audit='SMB share delete', audit_callback=True)
async def do_delete(self, audit_callback, id_):
"""
Delete SMB Share of `id`. This will forcibly disconnect SMB clients
Expand Down
Loading