Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130240 / 24.10 / skip known failing test #14078

Merged
merged 3 commits into from
Jul 25, 2024
Merged

NAS-130240 / 24.10 / skip known failing test #14078

merged 3 commits into from
Jul 25, 2024

Conversation

yocalebo
Copy link
Contributor

We have 1 failing API test and its this one. This is a known problem and the OS team has been made aware. They're working on a fix but it's complicated so we'll skip it for now. We have a high priority ticket internally.

@yocalebo yocalebo added the jira label Jul 25, 2024
@yocalebo yocalebo requested a review from a team July 25, 2024 10:51
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title skip known failing test NAS-130240 / 24.10 / skip known failing test Jul 25, 2024
@truenas truenas deleted a comment from bugclerk Jul 25, 2024
@anodos325
Copy link
Contributor

Instead of 100% skipping this test, can we just comment out the part that is failing?

@yocalebo
Copy link
Contributor Author

Instead of 100% skipping this test, can we just comment out the part that is failing?

yep, fixed it.

@yocalebo yocalebo merged commit 3e268a8 into master Jul 25, 2024
2 of 3 checks passed
@yocalebo yocalebo deleted the known-fail branch July 25, 2024 11:40
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants