Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-130193 / 24.10 / Correctly reference used ports key when validating app ports #14066

Merged
merged 1 commit into from
Jul 23, 2024
Merged

NAS-130193 / 24.10 / Correctly reference used ports key when validating app ports #14066

merged 1 commit into from
Jul 23, 2024

Conversation

sonicaj
Copy link
Member

@sonicaj sonicaj commented Jul 23, 2024

No description provided.

@sonicaj sonicaj added the jira label Jul 23, 2024
@sonicaj sonicaj requested a review from a team July 23, 2024 19:03
@sonicaj sonicaj self-assigned this Jul 23, 2024
@sonicaj sonicaj marked this pull request as ready for review July 23, 2024 19:04
@bugclerk bugclerk changed the title Correctly reference used ports key when validating app ports NAS-130193 / 24.10 / Correctly reference used ports key when validating app ports Jul 23, 2024
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-130193

1 similar comment
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-130193

@sonicaj sonicaj force-pushed the fix-port-validation-stuff branch from 99cb855 to ce0d162 Compare July 23, 2024 19:09
@sonicaj sonicaj requested a review from yocalebo July 23, 2024 19:09
@sonicaj sonicaj merged commit cbcd4f0 into master Jul 23, 2024
2 of 3 checks passed
@sonicaj sonicaj deleted the fix-port-validation-stuff branch July 23, 2024 19:26
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yocalebo yocalebo yocalebo approved these changes

Assignees

@sonicaj sonicaj

Labels
jira no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sonicaj @bugclerk @yocalebo