Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-130160 / 24.10 / Prevent bug tickets from vendored install #14062

Merged
merged 5 commits into from
Jul 24, 2024
Merged

NAS-130160 / 24.10 / Prevent bug tickets from vendored install #14062

merged 5 commits into from
Jul 24, 2024

Conversation

aiden3c
Copy link
Contributor

@aiden3c aiden3c commented Jul 23, 2024

On a vendored system, we want to prevent tickets made via the API from going through. On top of returning false in is_available, we also raise an error if the ticket creation API method is called directly.

I also updated the grub generation to match the paradigm in this PR.

If there are other areas that need to have these safeguards, let me know!

@bugclerk bugclerk changed the title Prevent bug tickets from vendored install NAS-130160 / 24.10 / Prevent bug tickets from vendored install Jul 23, 2024
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-130160

@aiden3c aiden3c requested a review from a team July 23, 2024 16:47
creatorcary added a commit that referenced this pull request Jul 23, 2024
@creatorcary
extra enum entry for #14062
d437c4f
creatorcary added a commit that referenced this pull request Jul 24, 2024
@creatorcary
NAS-130181 / 24.10 / Remove dotenv (#14061)
92d90c3 
* `load_envvars` replaces `dotenv_values`

* solve generator runtimeerror

* add vendor enum

* extra enum entry for #14062

* run after `ix-postinit.service`
@aiden3c aiden3c requested a review from a team July 24, 2024 12:26
@aiden3c aiden3c requested a review from a team July 24, 2024 13:12
@yocalebo yocalebo requested a review from anodos325 July 24, 2024 13:48
yocalebo
yocalebo approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@yocalebo yocalebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for @anodos325 final review before merge please!

@aiden3c aiden3c merged commit 05dae0f into master Jul 24, 2024
3 checks passed
@aiden3c aiden3c deleted the NAS-130160 branch July 24, 2024 16:03
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yocalebo yocalebo yocalebo approved these changes

@anodos325 anodos325 Awaiting requested review from anodos325

Assignees
No one assigned
Labels
no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aiden3c @bugclerk @anodos325 @yocalebo