Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-129907 / 24.10 / Fix logrotate to work properly #13978

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

Qubad786
Copy link
Contributor

@Qubad786 Qubad786 commented Jul 4, 2024

Problem

The current log rotation setup has two netdata configurations: the original one and the overwritten one. These conflicting configurations cause issues while rotating logs.

Solution

Remove the original Netdata log rotation configuration during the middleware package installation.

@Qubad786 Qubad786 added the jira label Jul 4, 2024
@Qubad786 Qubad786 requested a review from a team July 4, 2024 14:41
@bugclerk bugclerk changed the title Fix logrotate to work properly NAS-129907 / 24.10 / Fix logrotate to work properly Jul 4, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Jul 4, 2024

1 similar comment
@bugclerk
Copy link
Contributor

bugclerk commented Jul 4, 2024

@Qubad786 Qubad786 merged commit 26f6de4 into master Jul 4, 2024
2 of 3 checks passed
@Qubad786 Qubad786 deleted the mrehan/fix-logrotate branch July 4, 2024 15:06
@bugclerk
Copy link
Contributor

bugclerk commented Jul 4, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants