Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-129539 / 24.10 / always show rear nvme on m-series #13964

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

yocalebo
Copy link
Contributor

@yocalebo yocalebo commented Jul 2, 2024

Platform team notified us of a particular gen3 m40 SKU that actually has 4-rear nvme drive bays supported. The proposed and agreed upon solution is to always report 4 rear nvme drive bays for all mseries platforms since they all "have them" but some of them do not have the pcie switch that cables those bays up. The ones that do not have the pcie switch will still show 4 bays but they will always be empty. Not the most elegant but is the best solution.

@yocalebo yocalebo requested a review from a team July 2, 2024 19:02
@bugclerk bugclerk changed the title always show rear nvme on m-series NAS-129539 / 24.10 / always show rear nvme on m-series Jul 2, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Jul 2, 2024

@yocalebo yocalebo merged commit d9c8bb6 into master Jul 2, 2024
3 checks passed
@yocalebo yocalebo deleted the NAS-129539 branch July 2, 2024 20:42
@bugclerk
Copy link
Contributor

bugclerk commented Jul 2, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants