NAS-129780 / 24.10 / Simplify API for querying directory services users and groups #13942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anodos325
force-pushed
the
simplify-account
branch
3 times, most recently
from
45ce29d to
74a1f9b
Compare
bugclerk
changed the title
anodos325
force-pushed
the
simplify-account
branch
3 times, most recently
from
6ab30af to
5f892e1
Compare
bmeagherix
reviewed
Jun 28, 2024
bmeagherix
requested changes
Jul 1, 2024
There was a problem hiding this comment.
sshd_config.mako contains:
users = middleware.call_sync('user.query')
root_user = filter_list(users, [['username', '=', 'root']], {'get': True})
Presumably this should be updated. (And if not, maybe add a comment saying why not.)
plugins/smb.py share_precheck contains
local_smb_user_cnt = await self.middleware.call(
'user.query',
[['smb', '=', True]],
{'count': True}
)
should this also be updated? (And if not, maybe add a comment saying why not.)
bmeagherix
approved these changes
Jul 1, 2024
anodos325
force-pushed
the
simplify-account
branch
2 times, most recently
from
ffc7a35 to
2a7f966
Compare
Cache query responses are fast enough that we should include by default. Directory services users and groups can be reasonably omitted if filters explicitly call for local or builtin users. Remove currently-disabled old LDAP test and validate that DS users and groups returned via user.query and group.query. Add useful CallErrors if someone tries to modify DS user. Sometimes API consumers are over-enthusiastic about what they can do with users provided by AD / LDAP.
anodos325
force-pushed
the
simplify-account
branch
from
92497bf to
f00c944
Compare
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache query responses are fast enough that we should include by default. Directory services users and groups can be reasonably omitted if filters explicitly call for local or builtin users.