NAS-127613 / 24.10 / Add ES24N sensor support #13936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
Also add RedfishStatusHealth and RedfishStatusState enums
Refactor code and in an async map_jbof now call map_es24n in parallel. This will use the new AsyncRedfishClient to obtain various information from the JBOF redfish interface, which will then be mapped to a similar dict as is done for other enclosure types. This commit adds "Power Supply", "Cooling", "Temperature Sensors" and "Voltage Sensor" to the elements returned by map_es24n (was already returning "Array Device Slot").
anodos325
reviewed
Jun 27, 2024
| # FIXME: This function shouldn't exist and the OEM should fix | ||
| # this at some point. When they do (hopefully) fix the model, | ||
| # remove this function | ||
| expected_uri = '/redfish/v1/Chassis/2U24' |
There was a problem hiding this comment.
Should this be defined as a constant?
yocalebo
reviewed
Jun 27, 2024
|
Something I've noticed and should be considered. This area of our code is called quite a bit so the more logging statements we add, the more our log files will be spammed. When I wrote |
yocalebo
approved these changes
Jun 28, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
map_jbofasync and process JBOFs in parallel.Refactor code and in an async
map_jbofnow callmap_es24nin parallel. This will use the newAsyncRedfishClient(being added in PR #13913) to obtain various information from the JBOF redfish interface, which will then be mapped to a similardictas is done for other enclosure types.This commit adds "Power Supply", "Cooling", "Temperature Sensors" and "Voltage Sensor" to the elements returned by
map_es24n(was already returning "Array Device Slot").Abstracted out some strings from
ElementStatusandElementTypeto enums for reuse.