Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-129758 / 24.10 / Try to use persistent connection for CI tests #13935

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

anodos325
Copy link
Contributor

Store a persistent websocket client connection in the truenas_server object we allocate for test runs, and use this for general case where test simply uses call test utility. This is to avoid potentially running into issues with rate-limiting on auth endpoints.

@anodos325 anodos325 force-pushed the add-persistent-ws-connection branch 2 times, most recently from f88126d to 3086d53 Compare June 26, 2024 16:47
Store a persistent websocket client connection in the truenas_server
object we allocate for test runs, and use this for general case where
test simply uses `call` test utility. This is to avoid potentially
running into issues with rate-limiting on auth endpoints.
@anodos325 anodos325 force-pushed the add-persistent-ws-connection branch from a514b92 to 9b7cae1 Compare June 26, 2024 16:50
@anodos325 anodos325 requested a review from a team June 26, 2024 17:08
@anodos325 anodos325 added the jira label Jun 26, 2024
@bugclerk bugclerk changed the title Try to use persistent connection for CI tests NAS-129758 / 24.10 / Try to use persistent connection for CI tests Jun 26, 2024
@bugclerk
Copy link
Contributor

@anodos325 anodos325 requested a review from yocalebo June 26, 2024 17:10
@anodos325 anodos325 merged commit 9d38df1 into master Jun 26, 2024
2 of 3 checks passed
@anodos325 anodos325 deleted the add-persistent-ws-connection branch June 26, 2024 17:26
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants